gtest: internal: refactor common test functions out of sdpa #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syurkevi
force-pushed
the
syurkevi/internal_test_common_fn
branch
6 times, most recently
from
5ec56b6 to
b98d591
Compare
|
make test |
syurkevi
force-pushed
the
syurkevi/internal_test_common_fn
branch
2 times, most recently
from
15c6f28 to
4a63101
Compare
syurkevi
force-pushed
the
syurkevi/internal_test_common_fn
branch
from
4a63101 to
96a984a
Compare
umar456
approved these changes
Mar 5, 2025
dzarukin
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors internal testing for sdpa by extracting common testing functions out of sdpa specific code.
This is done in anticipation of testing gated mlp, paged attention, and other future fusions.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?