cpu: x64: jit_binary_kernel: pass src2_dt unconditionally #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
vpirogov
approved these changes
Feb 28, 2025
|
make test |
>cl --version Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30158 for x64 This version of compiler for C++17 (C++11 is fine) will generate wrong code for non-ternary algorithms due to the branch in the constructor. It inverts objects that must be created and must not: io_=0000028F599311D8 io_.at(conf_.src0_type)=0000000000000000 io_.at(conf_.src1_type)=0000000000000000 io_.at(conf_.src2_type)=0000028F59929C00 io_.at(conf_.dst_type)=0000000000000000 The solution is to pass src2_type unconditionally, access to such io_injector must be regulated by checking for is_ternary().
dzarukin
force-pushed
the
dzarukin/rls-v3.7/wa_jit_binary
branch
from
c7646cc to
9496130
Compare
|
make test |
avmanerikar
approved these changes
Feb 28, 2025
This was referenced Feb 28, 2025
densamoilov
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of compiler for C++17 (C++11 is fine) will generate wrong code for non-ternary algorithms due to the branch in the constructor. It inverts objects that must be created and must not:
The solution is to pass src2_type unconditionally, access to such io_injector must be regulated by checking for is_ternary().