build: explicitly set compile PDB names #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
changed the title
Cmake: explicitly set compile PDB names for object libraries, because the behavior is different between MSVC and Ninja generators: - MSVC uses target name as default name for compile PDB - Ninja uses vc<vs version>.pdb When you want to re-distribute such PDB files and move all files into a single folder, in later cases all files will override each other.
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino
that referenced
this pull request
Mar 3, 2025
### Details: - Use default `/Zi` instead of `/Z7`, which allows to reduce binary size of static libraries in debug build. - Create cpack component for PDB files and build them for Release, Debug and both static / dynamic builds. - Switched cmake generator for Windows static build to MSVC because of issue with default names for PDB files in Ninja. Can be reverted back once uxlfoundation/oneDNN#2795 is merged and used within OpenVINO. ### Tickets: - CVS-160554 - CVS-163245
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino
that referenced
this pull request
Mar 3, 2025
### Details: - Use default `/Zi` instead of `/Z7`, which allows to reduce binary size of static libraries in debug build. - Create cpack component for PDB files and build them for Release, Debug and both static / dynamic builds. - Switched cmake generator for Windows static build to MSVC because of issue with default names for PDB files in Ninja. Can be reverted back once uxlfoundation/oneDNN#2795 is merged and used within OpenVINO. ### Tickets: - CVS-160554 - CVS-163245
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino
that referenced
this pull request
Mar 3, 2025
### Details: - Use default `/Zi` instead of `/Z7`, which allows to reduce binary size of static libraries in debug build. - Create cpack component for PDB files and build them for Release, Debug and both static / dynamic builds. - Switched cmake generator for Windows static build to MSVC because of issue with default names for PDB files in Ninja. Can be reverted back once uxlfoundation/oneDNN#2795 is merged and used within OpenVINO. ### Tickets: - CVS-160554 - CVS-163245
|
@vpirogov could you please help with review? or assign proper people |
mgouicem
reviewed
Mar 7, 2025
mgouicem
approved these changes
Mar 10, 2025
vpirogov
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cmake: explicitly set compile PDB names for object libraries, because the behavior is different between MSVC and Ninja generators:
When you want to re-distribute such PDB files and move all files into a single folder, in later cases all files will override each other.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Performance improvements
New features
Bug fixes
RFC PR