Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: sycl: fix group norm build after quant refactor part 3 #2823

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

AD2605
Copy link
Contributor

@AD2605 AD2605 commented Mar 5, 2025

Description

#2746 got merged after #2733 , which did not reflect the changes for the scale/zero-point refactor.
This PR fixes the build issue of main when GPU_VENDOR is set to GENERIC

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@AD2605 AD2605 requested a review from a team as a code owner March 5, 2025 13:09
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Mar 5, 2025
@AD2605
Copy link
Contributor Author

AD2605 commented Mar 5, 2025

make test
disable benchdnn_all
disable build_vendor_intel
disable build_vendor_intel
disable test_device_cpu
disable arch_gpu_ampere
enable benchdnn_gnorm

@Rbiessy
Copy link
Contributor

Rbiessy commented Mar 5, 2025

Why the disable arch_gpu_ampere, what does it test?

@AD2605
Copy link
Contributor Author

AD2605 commented Mar 5, 2025

arch_gpu_ampere seems to turn on the testing for NVIDIA as the gpu vendor

Edit: I think I misunderstood the doc, that would be build_vendor_nvidia, arch_ampere_gpu adds a run on the A100 I suppose

@Rbiessy
Copy link
Contributor

Rbiessy commented Mar 5, 2025

I see, as long as there is one job that runs the generic backend with any NVidia device it should be enough for that PR. Thanks.

@AD2605
Copy link
Contributor Author

AD2605 commented Mar 5, 2025

make test
disable benchdnn_all
enable benchdnn_gnorm
disable build_vendor_intel
disable test_device_cpu
enable arch_gpu_ampere
enable build_vendor_generic
enable compiler_icx-oss

@AD2605
Copy link
Contributor Author

AD2605 commented Mar 5, 2025

PS: just came across the note that arch_gpu_ampere is required for build_vendor_generic (which is set by default, hence omitted in the previous run)

@AD2605 AD2605 merged commit f039820 into uxlfoundation:main Mar 6, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants