Bunch of functional fixes (fixes MFDNN-13193, fixes MFDNN-13282, fixes MFDNN-13236) #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzarukin
commented
Mar 5, 2025
dzarukin
commented
- Remove mask retrieval for the lowest precompute_scales calls as it's already determined based on the number of scales needed for weights.
- Restored the memory usage for scratchpad size after the refactor for a single implementation.
- Adjusted softmax threshold a little more to fit Windows threadpool output values.
- Added support for mode-modifier=M for sparse functionality. Metadata can't be generated with random values - it leads to an access a random memory location which is prohibited. Fill metadata as for correctness mode, rest buffer are kept with random values.
github-actions
bot
added
platform:cpu-x64
|
make test |
mgouicem
approved these changes
Mar 6, 2025
densamoilov
approved these changes
Mar 6, 2025
dzarukin
force-pushed
the
dzarukin/fixes
branch
from
b191ca1 to
ad7203c
Compare
github-actions
bot
added
the
documentation
|
make test |
avmanerikar
approved these changes
Mar 12, 2025
Adjustment for Eigen threadpool on Windows
Metadata must be filled properly to avoid random jumps in memory.
Performance mode must not protect memories.
If extra data is identical for both buffers, direct copy can handle that. Those buffers are never big, no need to parallelize the copy.
Parsing values for two global objects in a single function must be done carefully.
dzarukin
force-pushed
the
dzarukin/fixes
branch
from
e8a1d25 to
804ee20
Compare
vpirogov
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.