Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for broken links in documentation #2828

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fixes for broken links in documentation #2828

merged 3 commits into from
Mar 10, 2025

Conversation

vpirogov
Copy link
Contributor

@vpirogov vpirogov commented Mar 5, 2025

Fixes broken links:

Also removed dt and tag namespace shortcuts as these create confusion in annotated examples like this one.

@vpirogov vpirogov requested review from a team as code owners March 5, 2025 21:26
@github-actions github-actions bot added documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc component:examples labels Mar 5, 2025
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems copyright update to 2025 are missing.

@vpirogov vpirogov force-pushed the vpirogov/doc-fixes branch 2 times, most recently from 51e4f1c to c92d6a2 Compare March 6, 2025 18:01
@vpirogov
Copy link
Contributor Author

vpirogov commented Mar 9, 2025

@ranukund, please review

@vpirogov vpirogov requested a review from mgouicem March 9, 2025 19:09
Copy link
Contributor

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in graph examples.

Copy link
Contributor

@ranukund ranukund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes. Thanks!

Some examples define 'tag' and 'df' shortcuts to improve code
readability. This detail is misleading when looking at annotated
examples code that only shows code snippets.
@vpirogov vpirogov force-pushed the vpirogov/doc-fixes branch from c1ccb48 to 96467d2 Compare March 10, 2025 19:12
@vpirogov vpirogov merged commit 1adeab5 into main Mar 10, 2025
22 checks passed
@vpirogov vpirogov deleted the vpirogov/doc-fixes branch March 10, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants