common: disabling #pragma omp simd on windows debug builds #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzarukin
reviewed
Mar 7, 2025
vpirogov
reviewed
Mar 7, 2025
vpirogov
approved these changes
Mar 7, 2025
spalicki
force-pushed
the
spalicki/win_debug_simd
branch
2 times, most recently
from
df73011 to
0ec3163
Compare
mgouicem
approved these changes
Mar 7, 2025
spalicki
force-pushed
the
spalicki/win_debug_simd
branch
from
0ec3163 to
d00aa1a
Compare
spalicki
force-pushed
the
spalicki/win_debug_simd
branch
from
d00aa1a to
130f0d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#pragma omp simdon Windows debug builds in some corner cases creates incorrect code that leads to wrong results. We are disabling it using/Qopenmp-simd-compilation flag, but it seems to not be enough.