clang-tidy fixes in common headers #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:api
densamoilov
approved these changes
Mar 7, 2025
|
Apparently |
|
make test |
TaoLv
approved these changes
Mar 10, 2025
mgouicem
reviewed
Mar 10, 2025
vpirogov
force-pushed
the
vpirogov/tidy
branch
2 times, most recently
from
64404d8 to
cae9ed4
Compare
atkassen
approved these changes
Mar 11, 2025
mgouicem
approved these changes
Mar 11, 2025
Using default arguments in primitive descriptors is deliberate choice.
Co-authored-by: Andy Kassen <andrew.kassen@intel.com>
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses clang-tidy warnings detected with
ONEDNN_USE_CLANG_TIDY=CHECK_ALLin API, examples, and common.