Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: attr: switch off consistency check for now #2857

Merged
merged 1 commit into from
Mar 12, 2025
Merged

common: attr: switch off consistency check for now #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/common/primitive_attr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ bool post_ops_t::check_sum_consistency(const data_type_t dst_dt,
status_t post_ops_t::entry_t::validate_binary_with_dst_consistency(
const memory_desc_t *dst_md) const {
if (!is_binary()) return status::success;
// TODO: disable the check for now.
return status::success;

VCHECK_ATTR(dst_md->ndims == binary.user_src1_desc.ndims,
VERBOSE_INCONSISTENT_NDIMS_WITH_VALS, "dst", "bin_po",
Expand Down
3 changes: 2 additions & 1 deletion tests/gtests/dnnl_test_common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,8 @@ void test_fwd_pd_attr_po_binary(const engine &eng, bool supports_po_binary,
return;
}

EXPECT_ANY_THROW(pd_t pd(eng, prim_params..., attr_po_binary_bad));
// TODO: revert with the supplied change in the same commit.
// EXPECT_ANY_THROW(pd_t pd(eng, prim_params..., attr_po_binary_bad));
EXPECT_NO_THROW(pd_t pd(eng, prim_params..., attr_po_binary_good));
}

Expand Down