Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] xe: jit: gemm: remove vav from fp4 strategies #2873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GPU] xe: jit: gemm: remove vav from fp4 strategies #2873

wants to merge 1 commit into from
+9 −9

Conversation

dyoussif
Copy link
Contributor

fix out of registers issue in MFDNN-13301

@dyoussif dyoussif requested a review from a team as a code owner March 12, 2025 22:40
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Mar 12, 2025
@dyoussif
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul

@dyoussif dyoussif force-pushed the dyoussif/gemm_xe3_regs branch from 3e2adbb to 7c50d32 Compare March 13, 2025 17:06
@petercad
Copy link
Contributor

@dyoussif Did you verify the other fp4 strategies are working? When I run ktool -g on the oneDNN catalog it looks like they are all failing.

@dyoussif dyoussif force-pushed the dyoussif/gemm_xe3_regs branch from 7c50d32 to 091bc1a Compare March 13, 2025 21:41
@dyoussif
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul

@dyoussif
Copy link
Contributor Author

@dyoussif Did you verify the other fp4 strategies are working? When I run ktool -g on the oneDNN catalog it looks like they are all failing.

Kernel generation for these strategies should be fixed now.

@rjoursler
Copy link
Contributor

@dyoussif Did you verify the other fp4 strategies are working? When I run ktool -g on the oneDNN catalog it looks like they are all failing.

Would it make sense to just downstream ktool and add a new gtest which validates strategies?

@petercad
Copy link
Contributor

petercad commented Mar 17, 2025 •
edited
Loading

Would it make sense to just downstream ktool and add a new gtest which validates strategies?

We also were planning to move development to upstream gemmstone, which would also handle the same thing. But if that doesn't happen, I'd be in favor of the gtest. But I think we should avoid downstreaming all of ktool, instead factoring out the kernel generation check code.

@dyoussif dyoussif force-pushed the dyoussif/gemm_xe3_regs branch 2 times, most recently from 17c01d0 to fc6bf7f Compare March 18, 2025 02:55
@dyoussif
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_matmul

@dyoussif dyoussif force-pushed the dyoussif/gemm_xe3_regs branch from fc6bf7f to 23f153f Compare March 22, 2025 00:36
@dyoussif
Copy link
Contributor Author

make test
disable device_cpu
disable run_scans
disable benchdnn_all
enable benchdnn_nightly
enable benchdnn_matmul
enable benchdnn_ip
enable arch_xe-lp
enable arch_xe2-lpg
enable arch_xe3-lpg

@echeresh echeresh force-pushed the dyoussif/gemm_xe3_regs branch from 23f153f to cbda2ed Compare March 24, 2025 18:43
@dyoussif
Copy link
Contributor Author

make test
disable device_cpu
disable run_scans
disable benchdnn_all
enable benchdnn_nightly
enable benchdnn_matmul
enable benchdnn_ip
enable arch_xe-lp
enable arch_xe2-lpg
enable arch_xe3-lpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petercad petercad petercad approved these changes

@kealan-barbieri kealan-barbieri kealan-barbieri approved these changes

Assignees
No one assigned
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyoussif @petercad @rjoursler @kealan-barbieri