-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: clang-tidy: no repo ref #2925
Conversation
I don't understand what this change does exactly. Please explain. The issue we have after PR #2911 got promoted is that |
Looks like it is now running against a merge commit of the two branches that GitHub creates for the PR in the base repo. In the log for #2924:
|
This sounds reasonable, as it would reflect the state after the PR is merged. Shall we test whether it works like that for forks as well? |
This test is for fork. This #2911 worked fine for branches and it uses PR merge branch (example: https://github.com/uxlfoundation/oneDNN/actions/runs/13972297648/job/39116992717). The only issue is for forks, and deleting repo ref fixes the issue and allows default checkout to merge commit. |
I just meant that the merge exists as part of the base repo. The merge commit is made from the base branch and the head branch (be it in a fork or not). @hmaciak's test was with the branch from my fork and everything looked good. |
This PR provides fix for fork repositories check.