Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ukernel: x64: initialize amx palette once in finalize #2926

Merged
merged 1 commit into from
Mar 21, 2025
Merged

ukernel: x64: initialize amx palette once in finalize #2926

merged 1 commit into from
Mar 21, 2025

Conversation

mgouicem
Copy link
Contributor

@mgouicem mgouicem commented Mar 20, 2025 •
edited
Loading

This PR moves palette generation from brgemm::set_hw_context (which can be called many times by user in critical path) to brgemm::finalize (which is called once ahead of time).

fixes MFDNN-13158

@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 20, 2025
@mgouicem
Copy link
Contributor Author

make test
enable benchdnn_brgemm

@mgouicem mgouicem marked this pull request as ready for review March 21, 2025 07:48
@mgouicem mgouicem requested a review from a team as a code owner March 21, 2025 07:48
@mgouicem mgouicem merged commit a204c4b into main Mar 21, 2025
17 of 18 checks passed
@mgouicem mgouicem deleted the mgouicem/main/ukernel_cache_pallette branch March 21, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzarukin dzarukin dzarukin approved these changes

@inteldimitrius inteldimitrius inteldimitrius approved these changes

Assignees
No one assigned
Labels
platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgouicem @dzarukin @inteldimitrius