Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: x64: brgemm: fix assertion due to invalid EVEX offset #2928

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

rjoursler
Copy link
Contributor

@rjoursler rjoursler commented Mar 20, 2025

Fixes the following assertion due to offset calculated here on GPU large buffer tests on SPR systems by disabling brgemm for large buffers.

[rjoursle@sdpdnn630225 ~]$ ~/dnnl/build_debug/tests/benchdnn/benchdnn --mode-modifier=P --ip --engine=gpu --dt=bf16:bf16:f32 --stag=ab --dtag=ab mb21ic13oc133326203
terminate called after throwing an instance of 'Xbyak::Error'
  what():  offset is too big

Fixes MFDNN-13161.

@rjoursler rjoursler requested a review from a team as a code owner March 20, 2025 19:46
@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 20, 2025
@rjoursler rjoursler force-pushed the rjoursle/fix_large_brgemm branch from 0215f8f to 462cac0 Compare March 20, 2025 22:22
@rjoursler
Copy link
Contributor Author

make test

@rjoursler rjoursler merged commit a157fbe into main Mar 21, 2025
12 of 13 checks passed
@rjoursler rjoursler deleted the rjoursle/fix_large_brgemm branch March 21, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants