Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: align header guards to file names #2934

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

all: align header guards to file names #2934

wants to merge 5 commits into from

Conversation

atkassen
Copy link
Contributor

Updates header guards to align them with file name, adds missing header guards, and replaces one instance of #pragma once.

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@atkassen atkassen self-assigned this Mar 21, 2025
@atkassen atkassen requested review from a team as code owners March 21, 2025 20:59
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Mar 21, 2025
@atkassen atkassen changed the title xe: align header guards to file names gpu: align header guards to file names Mar 21, 2025
@atkassen atkassen force-pushed the akassen/header-guards branch from c4bb047 to f53aef5 Compare March 21, 2025 21:02
@atkassen atkassen force-pushed the akassen/header-guards branch 2 times, most recently from ae93790 to 4b844df Compare March 21, 2025 21:32
dzarukin
dzarukin approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@dzarukin dzarukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.
Would be nice to get a script that checks that and enforces the policy through the GH Actions...

@atkassen atkassen force-pushed the akassen/header-guards branch from 4b844df to cf69a55 Compare March 21, 2025 21:48
@atkassen
Copy link
Contributor Author

Thanks for taking care of this. Would be nice to get a script that checks that and enforces the policy through the GH Actions...

Of course I am not doing these things by hand... :) I can add it if there is value in it.

@atkassen atkassen force-pushed the akassen/header-guards branch from cf69a55 to 99bc076 Compare March 21, 2025 22:14
@atkassen atkassen requested review from a team as code owners March 21, 2025 22:14
@github-actions github-actions bot added platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd devops Github automation platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic component:graph-api Codeowner: @oneapi-src/onednn-graph labels Mar 21, 2025
@atkassen atkassen force-pushed the akassen/header-guards branch 2 times, most recently from 264fa04 to 9ba2b54 Compare March 21, 2025 22:18
@dzarukin
Copy link
Contributor

Thanks for taking care of this. Would be nice to get a script that checks that and enforces the policy through the GH Actions...

Of course I am not doing these things by hand... :) I can add it if there is value in it.

@vpirogov, would you find some value in such solution?

@atkassen atkassen force-pushed the akassen/header-guards branch 2 times, most recently from c662775 to e734b08 Compare March 24, 2025 16:14
@atkassen atkassen force-pushed the akassen/header-guards branch from 5f17b3c to 0bc30f1 Compare March 24, 2025 18:29
@atkassen atkassen force-pushed the akassen/header-guards branch from 0bc30f1 to f6c3e88 Compare March 24, 2025 18:29
@atkassen
Copy link
Contributor Author

make test

@atkassen atkassen changed the title gpu: align header guards to file names all: align header guards to file names Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoLv TaoLv TaoLv approved these changes

@spalicki spalicki spalicki approved these changes

@dzarukin dzarukin dzarukin approved these changes

@rjoursler rjoursler rjoursler approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@atkassen atkassen

Labels
component:graph-api Codeowner: @oneapi-src/onednn-graph devops Github automation platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atkassen @dzarukin @TaoLv @spalicki @rjoursler