ngen: update PVC WAR bug workaround #2935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petercad
force-pushed
the
petercad/pww_update
branch
from
636218a to
8136235
Compare
|
make test |
|
make test perf-gpu |
rjoursler
approved these changes
Mar 24, 2025
petercad
force-pushed
the
petercad/pww_update
branch
from
8136235 to
b4e8984
Compare
|
make test |
kealan-barbieri
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2864 / MFDNN-13404.
Followup to #2472, which introduces a workaround for a PVC HW bug related to write-after-send-read dependencies in the presence of heavy double precision usage. The workaround wasn't properly guarding against the bug in some cases where surrounding send instructions were predicated.
I also spotted and fixed another issue in the workaround.