-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xe: jit: remove unnecessary invasive gemmstone modifications #2943
Open
rjoursler
wants to merge
10
commits into
main
Choose a base branch
from
rjoursle/break_gemmstone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4164bf
to
1ba5098
Compare
b938a36
to
defa057
Compare
petercad
reviewed
Mar 26, 2025
88655ed
to
1fe1dda
Compare
petercad
reviewed
Mar 28, 2025
petercad
reviewed
Mar 28, 2025
petercad
reviewed
Mar 28, 2025
1fe1dda
to
56be449
Compare
1f1ede0
to
5cd9948
Compare
The oneDNN version of gemmstone has accumulated a number of invasive modifications to gemmstone. This patch starts the process of removing these invasive changes by moving gemmstone into its own namespace and removing simple oneDNN invasive dependencies. More complicated dependencies, such as those required for logging, post-ops, and micro-kernels are ignored for now.
More work needs to be done here, but is expected to be handled in future patches.
5cd9948
to
e4e1ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oneDNN version of gemmstone has accumulated a number of invasive modifications to gemmstone. This patch starts the process of removing these invasive changes by moving gemmstone into its own namespace and removing simple oneDNN invasive dependencies. More complicated dependencies, such as those required for logging, post-ops, and micro-kernels are ignored for now.