[rls-v3.8-pc] Fixed int4 weights alignment check in matmul #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
component:tests
|
make test |
avmanerikar
approved these changes
Mar 25, 2025
petercad
reviewed
Mar 25, 2025
| IMPLICATION(src_strides[d] > 1, src_strides[d] % 2 == 0), | ||
| VERBOSE_BAD_DIM, "src", d); | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems like we should factor out the check, but fine for this backport:
bool valid_subbyte_strides(const memory_desc &md, int *bad_dim) { ... }
/* ... */
VCHECK_MATMUL(valid_subbyte_strides(weights_desc, &bad_dim), VERBOSE_BAD_DIM, "weights", bad_dim);
VCHECK_MATMUL(valid_subbyte_strides(src_desc, &bad_dim), VERBOSE_BAD_DIM, "src", bad_dim);
petercad
approved these changes
Mar 25, 2025
mgouicem
approved these changes
Mar 25, 2025
vpirogov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of #2917.