-
Notifications
You must be signed in to change notification settings - Fork 87
fix: align icons and buttons in upload file row #8931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -123,6 +123,7 @@ const uploadFile = css` | |||
[part='commands'] { | |||
display: flex; | |||
align-items: baseline; | |||
align-self: flex-start; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just change it to use align-items: flex-start
everywhere. Using baseline as a default doesn't seem particularly useful for the elements that the upload file row contains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me that the whole row would be better implemented as a css grid... which we could definitely do in V25, and possibly in a minor.
@rolfsmeds Please take a look, I'm not sure if the changes are acceptable as a bugfix for a patch version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, start
equals flex-start
. It’s just shorter, less bytes.
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
|
Not quite: |
Rolf: oh, that’s good to know. Thanks! |
Description
Currently all flex containers in upload file row use
align-items: baseline
, which makes it hard to align icons and buttons with the first text line. Changed icons and the commands container that contains buttons to useflex-start
instead. Then applied the same solution we use for aligning icons and buttons with the first line of text in text area.This is potentially a breaking change as it changes default styles, appearance, as well as the default height of the component (it gets a bit smaller).
Fixes #8768
Type of change