Dashboard style update #8962
Dashboard style update #8962
Conversation
|
|
||
| :host::before { | ||
| content: ''; | ||
| display: block; |
There was a problem hiding this comment.
Minor nit, but this is not required, as absolute/fixed positioned elements become block containers automatically.
| display: block; |
| * `--vaadin-dashboard-item-rowspan` | rowspan of the widget | ||
| * Custom Property | Description | ||
| * --------------------------------------------|---------------------- | ||
| * `--vaadin-dashboard-item-colspan` | colspan of the widget |
There was a problem hiding this comment.
Should we align the naming for all the properties to maybe use --vaadin-dashboard-item-xyz?
|
We should probably add some visual tests for the themes. |
| * `--vaadin-dashboard-widget-shadow` | widget shadow (non edit mode) | ||
| * `--vaadin-dashboard-widget-editable-shadow` | widget edit mode shadow | ||
| * `--vaadin-dashboard-widget-selected-shadow` | selected widget shadow | ||
| * `--vaadin-dashboard-widget-padding` | padding around widget content |
There was a problem hiding this comment.
We should also add the new properties to the TS file.
| } | ||
|
|
||
| [part='title'] { | ||
| flex: 1; | ||
| color: var(--lumo-header-text-color); | ||
| margin: 0; | ||
| white-space: nowrap; | ||
| white-space: var(--vaadin-dashboard-widget-title-wrap, wrap); |
There was a problem hiding this comment.
This seems to be missing from the property list.
Added some tests. Can you check the baseline images @rolfsmeds ? |
|
Description
Fixes #8961
Fixes #8706
Type of change
Checklist
Additional for
Featuretype of change