fix: adjust number field button icon size to match other components #9026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
web-padawan
reviewed
Apr 30, 2025
There was a problem hiding this comment.
For the record, this changes touch target area from current 32px to 24px which would be kind of against the idea defined in vaadin/vaadin-text-field#359.
Note, the original fix in vaadin/vaadin-text-field#363 is somewhat outdated since icons were later updated in #2595.
The [part$='button'] selector should be changed anyway if we keep it, apparently it was a regression introduced in V22 when adding a new version of number-field in #2279 😕
|
web-padawan
reviewed
May 5, 2025
| @@ -21,15 +21,15 @@ const numberField = css` | |||
| padding: 0; | |||
| } | |||
|
|
|||
| [part$='button'] { | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
I guess we can keep cursor: pointer for now even though it's going to be removed in base styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9006
Type of change