Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opentelemetry sink): input() should delegate to internal config input() #22126

Merged
merged 4 commits into from
Jan 6, 2025
Merged

fix(opentelemetry sink): input() should delegate to internal config input() #22126

merged 4 commits into from
Jan 6, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 6, 2025 •
edited
Loading

Summary

Fix to input() function.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22054

@pront pront requested a review from a team as a code owner January 6, 2025 16:34
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jan 6, 2025
@pront pront changed the title fix(opentelemetry sink): input() should delegate to internal config i… fix(opentelemetry sink): input() should delegate to internal config input() Jan 6, 2025
@pront pront added the sink: opentelemetry Anything `opentelemetry` sink related label Jan 6, 2025
@pront pront requested a review from jszwedko January 6, 2025 16:38
@pront pront enabled auto-merge January 6, 2025 17:47
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/fix-otel-sink-input
Commit report: a7ccefe
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@pront pront added this pull request to the merge queue Jan 6, 2025
Merged via the queue into master with commit f59fd9c Jan 6, 2025
55 checks passed
@pront pront deleted the pront/fix-otel-sink-input branch January 6, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: sinks Anything related to the Vector's sinks sink: opentelemetry Anything `opentelemetry` sink related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko