Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(external docs): render array of object type in component docs #22138

Merged
merged 5 commits into from
Jan 9, 2025
Merged

chore(external docs): render array of object type in component docs #22138

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
330e4e3
Try to render array of object in component docs
titaneric Jan 7, 2025
1766060
Add some margin between rendering config-object in array block
titaneric Jan 7, 2025
a3d369c
Add some margin on top of config object and decrease the margin in ar…
titaneric Jan 8, 2025
40b255e
Remove array's `syntax` rendering since it's not defined in schema
titaneric Jan 9, 2025
ff6f9c8
conditional render syntax field for array type
titaneric Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions website/layouts/partials/data.html
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node that Line 119 (rendering config object) has the similar margin.

Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,15 @@

<span class="flex items-center space-x-1">
{{ partial "badge.html" (dict "word" $k "color" "gray") }}
{{ partial "badge.html" (dict "word" $v.syntax "color" "gray") }}
</span>
</span>

{{ if eq $k "object" }}
<div class="mt-2">
{{ template "config-object" (dict "name" $name "config" $v "level" 4) }}
</div>
{{ end }}

{{ with $v.examples }}
{{ template "config-array-examples" (dict "examples" .) }}
{{ end }}
Expand Down Expand Up @@ -1630,7 +1635,7 @@ <h3 id="{{ $code }}">

{{ define "config-array-examples" }}
{{ $json := .examples | jsonify (dict "indent" " ") }}
<div x-data="{ open: false }" class="mt-2.5 border rounded py-2 px-3 dark:border-gray-700">
<div x-data="{ open: false }" class="mt-2 border rounded py-2 px-3 dark:border-gray-700">
<span class="flex justify-between items-center">
<span class="text-sm">
Examples
Expand Down
Loading