chore(ci): major publish.yml refactoring #22151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
added
the
no-changelog
add missing needs section
pront
force-pushed
the
pront/publish-yml-refactoring
branch
from
e36814a to
9bdcc65
Compare
pront
commented
Jan 9, 2025
| name: Download Artifacts | ||
| runs-on: ubuntu-20.04 | ||
| needs: | ||
| - build-x86_64-unknown-linux-gnu-packages |
There was a problem hiding this comment.
I think these builds are also repetitive and can be refactored in another PR
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time |
|
Each job runs on a new clean runner, can't figure out how to share artifacts across jobs. Further refactoring has other complications. This is a low ROI PR as it stands so I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Experiment
Change Type
Is this a breaking change?
How did you test this PR?
https://github.com/vectordotdev/vector/actions/runs/12698476258
Does this PR include user facing changes?
Checklist
Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References
Ref: #22140