Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): remove obsolete mentions to netlify #22162

Merged
merged 5 commits into from
Jan 11, 2025
Merged

chore(website): remove obsolete mentions to netlify #22162

merged 5 commits into from
Jan 11, 2025
+29 −1,545

Conversation

pront
Copy link
Member

@pront pront commented Jan 10, 2025 •
edited
Loading

Summary

Cleanup netlify deps and mentions.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

cd website
make serve

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested review from a team as code owners January 10, 2025 19:47
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 10, 2025
@pront pront requested a review from jszwedko January 10, 2025 19:47
@github-actions GitHub Actions
Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@github-actions GitHub Actions
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

pront
pront commented Jan 10, 2025
View reviewed changes
website/package.json
"devDependencies": {
"@netlify/plugin-lighthouse": "^2.1.2"
}
"devDependencies": {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was updated by:

yarn remove @netlify/plugin-lighthouse

@jhgilbert jhgilbert self-assigned this Jan 10, 2025
jhgilbert
jhgilbert approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a very minor suggestion, thanks!

docs/REVIEWING.md Outdated Show resolved Hide resolved
jszwedko
jszwedko approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

website/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@pront pront enabled auto-merge January 10, 2025 19:56
@pront pront disabled auto-merge January 10, 2025 19:56
@pront @jhgilbert
Update docs/REVIEWING.md
b469ca9 
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
@pront pront enabled auto-merge January 10, 2025 19:57
@github-actions GitHub Actions
Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 10, 2025 •
edited
Loading

Datadog Report

Branch report: pront/remove-netlify-website
Commit report: e0554a2
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

@github-actions GitHub Actions
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@github-actions GitHub Actions
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@pront pront added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit bd976f1 Jan 11, 2025
41 checks passed
@pront pront deleted the pront/remove-netlify-website branch January 11, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhgilbert jhgilbert jhgilbert approved these changes

@jszwedko jszwedko jszwedko approved these changes

Assignees

@jhgilbert jhgilbert

Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pront @jszwedko @jhgilbert