Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): Add timezone option for parse_timestamp function #1207

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

titaneric
Copy link
Contributor

Summary

#962 mentions the possibility of adding timezone optional argument for parse_timestamp function. I find it it's rather easy to implement it, so I would give it a try.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

Closes: #962

Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you @titaneric. You are on a roll 🔥

Let's also prepare a sibling Vector PR to explain this new parameter.

@pront pront added this pull request to the merge queue Jan 6, 2025
Merged via the queue into vectordotdev:main with commit 890c123 Jan 6, 2025
14 checks passed
@titaneric
Copy link
Contributor Author

I have turned on the related PR and it's ready to review at vectordotdev/vector#22121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timezone support for parse_timestamp
2 participants