fix(build): import types from vega-lite
root instead of /src directory
#1463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lint and build
CI job #1462 (to unblock feat(editor): Add setting for using editor withexpressionInterpreter
enabled #1461)Changes
Config
/TopLevelSpec
to import fromvega-lite
root instead of fromvega-lite/src
, preventing extraneous typecheckingTesting
Notes
skipLibCheck: true
intsconfig.json
alone does not work to prevent typechecking node modules if we are referencing thesrc/
folder instead of sticking with the exportedvega-lite/src/index.ts
.editor/tsconfig.json
Line 17 in 780e299