Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): import types from vega-lite root instead of /src directory #1463

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Jan 27, 2025

Motivation

Changes

  • Changes Config / TopLevelSpec to import from vega-lite root instead of from vega-lite/src, preventing extraneous typechecking

Testing

  • CI passing should be sufficient, this doesn't make any functional changes.

Notes

  • TSC always failing starting being an issue after 25d5233
  • Setting skipLibCheck: true in tsconfig.json alone does not work to prevent typechecking node modules if we are referencing the src/ folder instead of sticking with the exported vega-lite/src/index.ts.

"skipLibCheck": true

@hydrosquall hydrosquall self-assigned this Jan 27, 2025
@hydrosquall hydrosquall marked this pull request as ready for review January 27, 2025 02:57
@hydrosquall hydrosquall changed the title fix(build): import types from vega-lite root instead of /src directory fix(build): import types from vega-lite root instead of /src directory Jan 27, 2025
@domoritz domoritz merged commit e034278 into master Jan 27, 2025
1 check passed
@domoritz domoritz deleted the cameron.yick/fix-ci-typecheck branch January 27, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Fix Lint and build CI job
2 participants