Merge pull request #139 from vict0rsch/old-arxiv

vict0rsch · Feb 2, 2023 · e5dd10d · e5dd10d
2 parents 0b7d6cc + 2d4750a
commit e5dd10d
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/src/background/background.js b/src/background/background.js
@@ -167,7 +167,7 @@ const fetchPWCData = async (arxivId, title) => {
 const findCodesForPaper = async (request) => {
     let arxivId, title, code;
     if (request.paper.source === "arxiv") {
-        arxivId = request.paper.id.split("-").last();
+        arxivId = request.paper.id.split("-").last().replace("_", "/");
     } else {
         title = request.paper.title;
     }

diff --git a/src/popup/js/popup.js b/src/popup/js/popup.js
@@ -239,7 +239,7 @@ const popupMain = async (url, is, manualTrigger = false) => {
         // -----  SVG clicks  -----
         // ------------------------
         addListener(`popup-memory-item-scirate--${id}`, "click", () => {
-            const arxivId = paper.id.split("-").last();
+            const arxivId = paper.id.split("-").last().replace("_", "/");
             const scirateURL = `https://scirate.com/arxiv/${arxivId}`;
             chrome.tabs.update({ url: scirateURL });
             window.close();

diff --git a/src/popup/min/popup.min.js b/src/popup/min/popup.min.js
diff --git a/src/shared/js/utils/paper.js b/src/shared/js/utils/paper.js
@@ -696,7 +696,8 @@ const parseIdFromUrl = async (url) => {
             .replace("/abs/", "/pdf/")
             .split("/pdf/")[1]
             .replace(".pdf", "")
-            .split("v")[0];
+            .split("v")[0]
+            .replace("/", "_");
         idForUrl = `Arxiv-${arxivId}`;
 
         const existingIds = Object.values(global.state.titleHashToIds).find((ids) =>

diff --git a/src/shared/js/utils/parsers.js b/src/shared/js/utils/parsers.js
@@ -18,7 +18,7 @@ const flipAndAuthors = (authors) =>
 // -------------------
 
 const fetchArxivXML = async (paperId) => {
-    const arxivId = paperId.replace("Arxiv-", "");
+    const arxivId = paperId.replace("Arxiv-", "").replace("_", "/");
     return fetch(
         "https://export.arxiv.org/api/query?" +
             new URLSearchParams({ id_list: arxivId })
@@ -304,14 +304,14 @@ const makeArxivPaper = async (url) => {
         year +
         firstNonStopLowercase(title);
 
-    const id = `Arxiv-${arxivId}`;
+    const id = `Arxiv-${arxivId.replace("/", "_")}`;
 
     let bibtex = "";
     bibtex += `@article{${key},\n`;
     bibtex += `    title={${title} },\n`;
     bibtex += `    author={${author} },\n`;
     bibtex += `    year={${year}},\n`;
-    bibtex += `    journal={arXiv preprint arXiv: ${id}}\n`;
+    bibtex += `    journal={arXiv preprint arXiv: ${arxivId}}\n`;
     bibtex += `}`;
 
     const venue = "";

diff --git a/src/shared/min/utils.min.js b/src/shared/min/utils.min.js