fix: lighting WebGPU shaders #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Mar 29, 2025
| @@ -54,7 +54,8 @@ export function getShaderLayoutBinding( | |||
| ): BindingDeclaration | null { | |||
| const bindingLayout = shaderLayout.bindings.find( | |||
| binding => | |||
| binding.name === bindingName || `${binding.name}uniforms` === bindingName.toLocaleLowerCase() | |||
| binding.name === bindingName || | |||
| `${binding.name.toLocaleLowerCase()}uniforms` === bindingName.toLocaleLowerCase() | |||
There was a problem hiding this comment.
Nit: Not completely sure I understand why we need this... Is it JS or WebGPU that is causing the issue. Regardless, no major objection, other than it often being better to fix issues at the source rather than loosening semantics.
There was a problem hiding this comment.
@ibgreen it depends on how the end-user names uniforms in their shader, so WGSL really. the previous implementation would only work for all-lower-case names like lighting or project, but would fail if the user named a uniform in camelCase like pointCloud, for example. i figured it's not something we have direct control over for custom layers/shaders so probably need to be flexible and handle that case.
ibgreen
pushed a commit
that referenced
this pull request
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for visgl/deck.gl#9531 in order to port point-cloud-layer to WebGPU.
Change List
pointCloud)wgsl_reflectas the version being used crashes when encoutering a switch statement with multiple comma-separatedcases when one case isdefault.