Skip to content

refactor(ssr): remove ssrTransform line offset preservation #19829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Apr 10, 2025

Description

Partially revert #19004 to remove line offset preservation logic as a minor simplification. This is not necessary anymore on Vitest after vitest-dev/vitest#7557 and this transform was also a best effort basis and didn't cover all scenarios (e.g. comments and exports in between).

@hi-ogawa
Copy link
Collaborator Author

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vite@19829

commit: 281b797

@vite-ecosystem-ci

This comment was marked as outdated.

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 281b797: Open

suite result latest scheduled
vite-environment-examples success failure
storybook failure failure
vite-plugin-react failure failure
vike success failure
waku success failure

laravel, marko, ladle, astro, quasar, nuxt, previewjs, analogjs, react-router, qwik, histoire, rakkas, vite-plugin-react-swc, vite-plugin-pwa, sveltekit, vite-plugin-cloudflare, unocss, vite-plugin-vue, vite-plugin-svelte, vite-setup-catalogue, vuepress, vitest, vitepress

@hi-ogawa hi-ogawa marked this pull request as ready for review April 10, 2025 02:44
@sapphi-red
Copy link
Member

I think we should wait merging this until next major as

  • this would break older Vitest versions + Vite after this PR
  • the next major is soon
  • keeping this is a small burden

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) feat: ssr breaking change labels Apr 10, 2025
@sapphi-red sapphi-red added this to the 7.0 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants