Skip to content

chore: use rolldown-plugin-dts for dts bundling #19990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 2, 2025

Description

This PR replaces rollup + rollup-plugin-dts with rolldown + rolldown-plugin-dts.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 2, 2025
@sapphi-red sapphi-red force-pushed the chore/switch-to-rolldown-dts branch from 1570128 to accd137 Compare May 19, 2025 05:46
@sapphi-red sapphi-red force-pushed the chore/switch-to-rolldown-dts branch from accd137 to 49e0349 Compare May 20, 2025 10:16
@sapphi-red sapphi-red marked this pull request as ready for review May 20, 2025 10:17
patak-dev
patak-dev previously approved these changes May 20, 2025
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to wait until rolldown/rolldown#4324 is resolved, but it is probably ok to move forward to have the whole build pipeline driven by rolldown.

@sapphi-red
Copy link
Member Author

I've pushed a commit that removes unnecessary entries in ignoreConfusingTypeNames. I also added a check for that.

@sapphi-red
Copy link
Member Author

It would be nice to wait until rolldown/rolldown#4324 is resolved, but it is probably ok to move forward to have the whole build pipeline driven by rolldown.

The type name in the error is not ideal, but I think it's ok for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants