Fix how we generate the query serving error documentation #17516
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small change introduced to our error code led to the query serving error documentation generation to not work as expected: It was trying to parse the arguments (%s, %d, etc) in the strings and was printing things like
'%!s(MISSING)'
instead of'%s'
. The issue is visible in this PR, specifically this commit: vitessio/website@98b15a1
(#1905).We should backport this to 21.0 as the issue was first introduced there.
I have updated vitessio/website#1905 with the newly generated docs for each branch (from 19 to main).