Skip to content

Commit

Permalink
Move tests into separate workflow (#1887)
Browse files Browse the repository at this point in the history
This is done to ensure that the "Test Report"-workflow always works,
even if the "Lint"-workflow fails before running the tests.
  • Loading branch information
johnnyomair authored Mar 26, 2024
1 parent d8eece4 commit 341038d
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 11 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,3 @@ jobs:
pnpm run lint
# check for duplicate ids of formatted messages
pnpm run intl:extract
- name: Test
run: pnpm run test

- name: Upload test results
uses: actions/upload-artifact@v3
if: success() || failure()
with:
name: test-results
path: packages/**/junit.xml
2 changes: 1 addition & 1 deletion .github/workflows/test-report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "Test Report"
on:
workflow_run:
workflows: ["Lint"]
workflows: ["Test"]
types:
- completed
jobs:
Expand Down
55 changes: 55 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Test

on:
pull_request:
types:
- opened
- synchronize
- reopened
push:
branches:
- main
- next

jobs:
test:
name: Test
runs-on: ubuntu-latest
steps:
- run: echo "${{ github.actor }}"

- uses: actions/checkout@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
- run: |
git config user.name github-actions
git config user.email github-actions@github.com
- uses: pnpm/action-setup@v2
with:
version: 8

- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18
registry-url: "https://registry.npmjs.org"
cache: "pnpm" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

- run: pnpm install --frozen-lockfile

- name: Copy schema files
run: pnpm run copy-schema-files

- name: Build
run: pnpm run build:packages

- name: Test
run: pnpm run test

- name: Upload test results
uses: actions/upload-artifact@v3
if: success() || failure()
with:
name: test-results
path: packages/**/junit.xml

0 comments on commit 341038d

Please sign in to comment.