Adapt ChangesCheckerInterceptor to more strict checking of content …

…scopes (#1773)

It's ugly but since the ChangesCheckerInterceptor will be deleted in v7
anyway this will serve as a workaround meanwhile.

---------

Co-authored-by: Johannes Obermair <johannes.obermair@vivid-planet.com>

.changeset/tough-onions-march.md

@@ -0,0 +1,5 @@
+---
+"@comet/cms-api": patch
+---
+
+Don't fail in ChangesCheckerInterceptor because of stricter content scope check

packages/api/cms-api/src/builds/changes-checker.interceptor.ts

@@ -29,7 +29,14 @@ export class ChangesCheckerInterceptor implements NestInterceptor {
                     this.reflector.get<string[]>(SKIP_BUILD_METADATA_KEY, context.getClass());
 
                 if (!skipBuild) {
-                    const scopes = await this.contentScopeService.inferScopesFromExecutionContext(context);
+                    let scopes: ContentScope[] | null;
+                    try {
+                        scopes = await this.contentScopeService.inferScopesFromExecutionContext(context);
+                    } catch (error) {
+                        // We might land here when an @AffectedEntity does not have a @ScopedEntity decorator
+                        // (this was formerly ignored but now throws an error because it's essential for the scope check)
+                        scopes = null;
+                    }
                     if (scopes) {
                         for (const scope of scopes) {
                             if (process.env.NODE_ENV === "development" && this.changeAffectsAllScopes(scope)) {
@@ -42,6 +49,16 @@ export class ChangesCheckerInterceptor implements NestInterceptor {
 
                             await this.buildsService.setChangesSinceLastBuild(scope);
                         }
+                    } else {
+                        if (process.env.NODE_ENV === "development") {
+                            if (operation.name) {
+                                console.warn(`Mutation "${operation.name.value}" affects all scopes. Are you sure this is correct?`);
+                            } else {
+                                console.warn(`Unknown mutation affects all scopes. Are you sure this is correct?`);
+                            }
+                        }
+
+                        await this.buildsService.setChangesSinceLastBuild("all");
                     }
                 }
             }