COM-39: Collapsed menu #1233
Merged
COM-39: Collapsed menu #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! feat(Menu): add MenuGroupSection component
|
thomasdax98
requested review from
jamesricky
and removed request for
thomasdax98
Co-authored-by: Ricky James Smith <jamesricky@me.com>
jomunker
force-pushed
the
collapsed-menu
branch
from
874882e to
a3cf811
Compare
johnnyomair
requested changes
Sep 28, 2023
johnnyomair
reviewed
Oct 10, 2023
…pProps Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
reviewed
Jan 23, 2024
johnnyomair
reviewed
Jan 29, 2024
jomunker
force-pushed
the
collapsed-menu
branch
from
8f83bea to
fd9eb4d
Compare
johnnyomair
reviewed
Feb 6, 2024
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
previously approved these changes
Feb 6, 2024
|
Please wait for @jamesricky's review |
jamesricky
reviewed
Feb 7, 2024
|
The implementation seems to differ from the Design:
Also the height of the icons changes, when opening/closing the menu: Screen.Recording.2024-02-07.at.16.42.16.mov |
|
@jomunker Are these concerns fixen in the follow-up PRs? If not, please fix |
1 task
Some of them are fixed in the follow-up PR but not all of them. I'll fix them there to simplify merging. For your reference I'll post a screen rec |
Screen.Recording.2024-02-13.at.15.35.28.mov |
thomasdax98
previously approved these changes
Feb 19, 2024
lgtm @jamesricky Can you also comment? |
jomunker
dismissed stale reviews from thomasdax98 and johnnyomair
via
5785d7d
Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com>
johnnyomair
approved these changes
Feb 22, 2024
jamesricky
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the Menu will stay open in collapsed variant showing only the icons.
Note: The chevron arrows which are currently cut of will be fixed in another PR.
Screen recording
Screen.Recording.2023-08-21.at.14.17.48.mov