Use of services for all block fixtures

[raphaelblum]

fixtures for all blocks in the page-content.block.ts + typing in page-content.generator.ts to enforce creating a fixture when adding a block to the page-content.block.ts

Screen.Recording.2023-09-15.at.12.21.44.mov

[johnnyomair]

Should we use generator, or fixture service?

[johnnyomair]

@nsams what's your opinion on this? Having a service for each block results in a lot of services, but using DI is definitely better than passing repositories/services around in generator functions

[raphaelblum]

Should we use generator, or fixture service?

For the page and link fixtures the name "generator" was to generic, and I agree:
#968 (comment)

So I would call them here fixture service as well.

[johnnyomair]

Two thoughts:

1. The generators generate the block input, and not the block data. Should we change the method names to generateBlockInput()?
2. How do you plan to move parts of the generators in the library?

[raphaelblum]

1. The generators generate the block input, and not the block data. Should we change the method names to generateBlockInput()?

yes, I'll update it

2. How do you plan to move parts of the generators in the library?

Every block that exists in the library should also have a fixture generator in the library (+ some configuration options will be required I think, for example the videos for the youtube video block should probably be defined in the project and not in the library)

For new blocks in the project, a new fixture file has to be created manually in the project. (Although I would also like this to be automated, perhaps an extension of the api generator?)