Merge next into ubernext #1416
Closed
Merge next into ubernext #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new non-nullable `isInboxFromOtherScope` column introduced in #1192 caused the migration to fail. Adding a default value resolves the issue.
Prevent slug change of home page in updateNode() and updateNodeSlug() of PageTreeService
Currently an exception is thrown if `null` is sent in order to remove a relation with an integer id. This fixes the exception and if undefined is sent (or rather, if the field is not sent at all) , this works as well and the relation remains untouched. Co-authored-by: Johannes Huber <johannes.huber@vivid-planet.com>
The migrations from both the library and the application were not sorted by timestamp. This prevented certain workarounds, for instance, adding an "earlier" migration to fix schema issues discovered at a later point.
Scoped mutations would cause a change for all scopes when querying a field resolver with `fieldResolverEnhancers: ["interceptors"]` enabled in the `GraphQLModule` config. This is due to using `operator.operator` to check whether an operation is a mutation. To fix this, we now use `parentType.name`, as recommended in the [Nest docs](https://docs.nestjs.com/graphql/other-features#execute-enhancers-at-the-field-resolver-level).
Merge main into next
The old files are not really in a good shape and not maintained. Switch to the generated ones to fix all problems...
This PR adds a better evaluation of different Youtube URL formats to the site block. Also Youtube links are now validated in the admin and a validation message is shown.
This PR adds an image preview when hovering over image thumbnails in the assets tab.
Replaces `CircularProgress` with our `BallTriangle` icon in the `Loading` component Unfortunately, that's a breaking change because the `CircularProgressProps` was passed through. I replaced that with the `SvgIconProps`, although it's debatable if passing the props through is needed at all. --------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
The `EditPage` component would push `${match}/content` to the browser
history when trying to save an invalid block, resulting in navigating
away from where the error occurred. Removing the push resolves the
issue.
Previously the dependencies of a SeoBlock were not added to the Page dependencies.
The implementation of `moveBlock` was flawed. Moving blocks by swapping only works if the move happens between directly adjacent blocks. However, there are scenarios where the move should be performed between non-adjacent blocks, for instance when a block is dragged outside the block list (see screencasts). To fix this, we change the implementation to move by removing the block at the `from` index and inserting it at the `to` index.
The `id` of an entity may be an integer. The CRUD generator previously assumed IDs to always be strings. This change adds support for integer IDs in all operations. When using an integer ID, `number` is used as type for the ID and a transform to convert the passed GraphQL argument to a number is added.
- Add new icons intended to be used in the RTE to `@comet/admin-icons` - Replace the current icons in the RTE toolbar with new icons from `@comet/admin-icons` - Change how `maxVisible` in `FeaturesButtonGroup` works: - If maxVisible = 4 and there are four features -> all four features (and no dropdown) are shown - If maxVisible = 4 and there are five features -> three features and the dropdown (containing two features) are shown
It was previously added as a peer dependency, leading to a breaking change
Minimal PR template with a reminder to add a changeset (because I forget the changeset so often)
# Releases ## @comet/admin-icons@4.6.0 ### Minor Changes - c3b7f99: Add new icons intended to be used in the RTE - c3b7f99: Change how `maxVisible` in `FeaturesButtonGroup` works: - If maxVisible = 4 and there are four features -> all four features (and no dropdown) are shown - If maxVisible = 4 and there are five features -> three features and the dropdown (containing two features) are shown ## @comet/admin-rte@4.6.0 ### Patch Changes - c3b7f99: Replace current icons in the RTE toolbar with new icons from `@comet/admin-icons` ## @comet/blocks-admin@4.6.0 ### Patch Changes - 031d86e: Fix drag and drop reordering in collection blocks ## @comet/cms-admin@4.6.0 ### Patch Changes - c3b7f99: Replace current icons in the RTE toolbar with new icons from `@comet/admin-icons` ## @comet/cms-api@4.6.0 ### Patch Changes - f6f7d4a: Prevent slug change of home page in `updateNode()` and `updateNodeSlug()` of `PageTreeService`
Show an error message if a file in the /icons directory doesn't contain valid SVG code.
Merge main into next
Otherwise, blocks in seo are not indexed in the block index Copy of vivid-planet/comet-starter#34
…1402) Make `replaceDependenciesInOutput()` required in the `DocumentInterface` In practice, this will be added by https://github.com/vivid-planet/comet/blob/next/packages/admin/cms-admin/src/documents/createDocumentRootBlocksMethods.ts anyway Changeset in #1401
Add missing changesets for v5
This PR adds a final form save button, which should be used in the future instead of the FinalFormSaveSplitButton.
This pull request changes the page tree loading behavior. Instead of displaying a CircularProgress continuously during focus polling, it now shows a LinearProgress after the initial loading of the page tree.
Add support for TypeScript paths (e.g., `@src/`) by using the project's TSConfig. --------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Add correct @comet/create-app command to docs
Merge main into next
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Merge main into next
Merge next into main
✅ Deploy Preview for comet-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for comet-dxp-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #1412 first