-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FinalFormFileSelect
#1461
Add FinalFormFileSelect
#1461
Conversation
@NataliaVizintini is this really draft? Or do you want a review? |
@johnnyomair as I mentioned in our conversation, I need your feedback to continue the development, because I don't think the component is ready yet. Therefore it's a draft and I want a review, please. |
0b374b4
to
82d8f9c
Compare
c754748
to
ff74d96
Compare
dfb1b95
to
13d9a71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a few styling differences between the design and the implementation:
Design | Implementation |
---|---|
- The height and border-color of the droppable area
- The button color
- The height of the items in the uploaded files list
- The space between the uploaded files list and the "Maximum file size" text
- The icon used in the error state should be a "!" but is an "i"
Also, the min-width's prevent the field from shrinking beyond a certain width:
This seems unnecessary to me.
Is there a specific reason for this, or could we remove that?
file.upload.resizing.mov
Ah, just saw the comment from @johnnyomair, that makes sense. Then I think |
Please check with the UX-Team if you're unsure if the design is correct. @thomasdax98 The black button seems to be the new secondary variant in the design, in the current implementation (in
Good point, we'll leave it as is then for now 👍🏼
There is also a margin in addition to the gap, so the total space is more than 10px.
👍🏼 |
FinalFormChooseFileField
)FinalFormFileSelect
)
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@thomasdax98 @jamesricky please review once again, thanks! |
587ab81
to
5086faf
Compare
5086faf
to
494781e
Compare
Co-authored-by: Ricky James Smith <jamesricky@me.com>
59ae1b6
to
60a666b
Compare
FinalFormFileSelect
)FinalFormFileSelect
COM-81 - File Upload Form Field
FileUpload Field with Dropzone