Display errors correctly on Unauthenticated-Status #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraxachun
force-pushed
the
error-unauthenticated
branch
2 times, most recently
from
da74689 to
1f6e6d7
Compare
fraxachun
force-pushed
the
error-unauthenticated
branch
from
1f6e6d7 to
f2307f0
Compare
nsams
reviewed
Jan 26, 2024
johnnyomair
reviewed
Jan 29, 2024
packages/admin/admin/src/error/errordialog/createErrorDialogApolloLink.tsx
Outdated
Show resolved
Hide resolved
…olloLink.tsx Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
previously approved these changes
Jan 30, 2024
nsams
previously approved these changes
Jan 31, 2024
|
@fraxachun please resolve conflicts, thanks! |
fraxachun
force-pushed
the
error-unauthenticated
branch
from
0288ee5 to
0cddf32
Compare
|
johnnyomair
approved these changes
Feb 13, 2024
fraxachun
added a commit
to vivid-planet/comet-charts
that referenced
this pull request
Feb 21, 2024
Improves error messaging, especially in conjunction with vivid-planet/comet#1624
fraxachun
added a commit
to vivid-planet/comet-charts
that referenced
this pull request
Mar 27, 2024
Improves error messaging, especially in conjunction with vivid-planet/comet#1624
fraxachun
added a commit
to vivid-planet/comet-charts
that referenced
this pull request
Apr 18, 2024
Improves error messaging, especially in conjunction with vivid-planet/comet#1624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types of error shouldn't normally appear if the AuthProxy is configured correctly. However, if it happens this improves the error messaging when in an ErrorBoundary or CurrentUserProvider (which normally is the outermost component which calls the API).
Also throw the correct Exception in the CometGuard and append the underlying error message (though don't show it to the user as like mentioned before this normally should not happen).