Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge next into feature/refactor-admin-component-theming #1627

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
60f5208
Fix encoding of special characters in filename (#1532)
thomasdax98 Jan 2, 2024
51d6c2b
Move soft-hyphen functionality to `@comet/admin-rte` (#1510)
andrearutrecht Jan 2, 2024
087cb01
Fix: Enable copying documents from one `PageTree` category to another…
thomasdax98 Jan 4, 2024
ba80016
Allow passing a mix of elements and arrays to `Tabs` and `RouterTabs`…
thomasdax98 Jan 4, 2024
981bf48
Pass `tooltipText` through to RTE custom-inline-styles toolbar butto…
jamesricky Jan 4, 2024
df5c959
Remove DAM license types micro and subscription (#1531)
jomunker Jan 8, 2024
e146d8b
Add support for external DAMs (#1225)
max-debug022 Jan 9, 2024
f398c22
Increase JSON request limit to avoid 413 errors (#1541)
thomasdax98 Jan 9, 2024
5208f16
Version Packages (#1523)
github-actions[bot] Jan 9, 2024
627c877
Merge main into next
invalid-email-address Jan 9, 2024
ead0135
Resolve conflicts
johnnyomair Jan 9, 2024
daa4b48
Merge pull request #1536 from vivid-planet/merge-main-into-next
thomasdax98 Jan 9, 2024
8a65515
Add Admin Server to PNPM (#1553)
johnnyomair Jan 10, 2024
5ef25c1
Merge branch 'main' into next
invalid-email-address Jan 10, 2024
75a17f5
Merge pull request #1554 from vivid-planet/merge-main-into-next
johnnyomair Jan 10, 2024
3adf867
Update webpack to 5.89.0 (#1556)
johnnyomair Jan 10, 2024
65a16a7
Merge main into next
invalid-email-address Jan 10, 2024
ec382ca
Resolve conflicts
johnnyomair Jan 10, 2024
d829e2c
Merge pull request #1557 from vivid-planet/merge-main-into-next
thomasdax98 Jan 10, 2024
bb2c76d
Rename `download` helper (#1521)
johnnyomair Jan 11, 2024
62bf8c6
Merge `core.js` and `core-without-import.js` ESLint configs (#1566)
johnnyomair Jan 15, 2024
7036a8d
Clean generated files before build (#1576)
johnnyomair Jan 16, 2024
ed6f9f1
Add real error message to `PageTreeReadApi#getNodeOrFail` (#1578)
thomasdax98 Jan 16, 2024
7d328a1
Improve `OneOfBlock` error message when `attachedBlocks` is undefined…
johnnyomair Jan 16, 2024
c4639be
Clip crop values when cropping an image (#1561)
thomasdax98 Jan 16, 2024
6277912
Change the signatures of `shouldScrollToField`, `shouldShowFieldError…
thomasdax98 Jan 16, 2024
85aa962
Set unhandled dependencies to undefined when copying to another scope…
thomasdax98 Jan 16, 2024
80a6d8d
Fix import restriction for MUI Alert (#1577)
johnnyomair Jan 17, 2024
1b37b1f
Show `additionalToolbarItems` in `ChooseFileDialog` (#1582)
johnnyomair Jan 17, 2024
32414d6
Release v5.5.0 (#1565)
github-actions[bot] Jan 17, 2024
49290cb
Remove outdated comments about public `BlockInputInterface`s in block…
Flips2001 Jan 17, 2024
7dfa2bc
Merge main into next
invalid-email-address Jan 17, 2024
f8e8044
Fix conflicts
thomasdax98 Jan 17, 2024
e377111
Merge pull request #1564 from vivid-planet/merge-main-into-next
thomasdax98 Jan 17, 2024
fd10b80
Add support for a custom block name and migrations to `createRichText…
stekalt Jan 18, 2024
fb52598
Move `comet-config.json` to `src/` folder (#1593)
johnnyomair Jan 18, 2024
fb6c806
Change `DataGrid`'s `noRowsLabel` from "No rows" to "No results found…
thomasdax98 Jan 23, 2024
d86d5a9
Make sites config generic (#1594)
johnnyomair Jan 23, 2024
03e6a77
Add support for anchor link items in `MasterMenu` (#1590)
lllHuber Jan 23, 2024
fe26a6e
Add better errors for non-existing and archived documents (#1567)
thomasdax98 Jan 23, 2024
3ee4ce0
Return newly uploaded items from `useDamFileUpload#uploadFiles` (#1610)
thomasdax98 Jan 23, 2024
76f85ab
Fix linking from block preview to block admin for non-trivial composi…
nsams Jan 23, 2024
38de946
Remove SQL defaults from `@comet/cms-api` (#1477)
dkarnutsch Jan 23, 2024
a9ac130
Ignore automatic pull requests when auto-assigning (#1612)
johnnyomair Jan 23, 2024
c4a3fa9
Release v5.6.0 (#1592)
github-actions[bot] Jan 23, 2024
921f637
Add `helperText` prop to `Field` and `FieldContainer` (#1562)
andrearutrecht Jan 24, 2024
5df6093
Merge branch 'main' into next
invalid-email-address Jan 24, 2024
573845f
Merge pull request #1591 from vivid-planet/merge-main-into-next
johnnyomair Jan 24, 2024
8e86516
Revert Next.js Preview Mode (#1617)
fraxachun Jan 25, 2024
298da50
Allow setting Content Scopes for each permission (#1524)
fraxachun Jan 26, 2024
84e3e1f
Remove dynamic formatted message ids (#1622)
fraxachun Jan 26, 2024
f820f4d
Merge remote-tracking branch 'origin/next' into merge-next-into-featu…
jamesricky Jan 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .changeset/eighty-tools-fail.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/eleven-impalas-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": minor
---

Add `helperText` prop to `Field` and `FieldContainer` to provide additional information
22 changes: 0 additions & 22 deletions .changeset/fifty-crabs-love.md

This file was deleted.

43 changes: 43 additions & 0 deletions .changeset/rich-crews-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
"@comet/cms-admin": major
---

Make sites config generic

The sites config was previously assumed to be `Record<string, SiteConfg>`.
However, as the sites config is solely used in application code, it could be of any shape.
Therefore, the `SitesConfigProvider` and `useSitesConfig` are made generic.
The following changes have to be made in the application:

1. Define the type of your sites config

Preferably this should be done in `config.ts`:

```diff
export function createConfig() {
// ...

return {
...cometConfig,
apiUrl: environmentVariables.API_URL,
adminUrl: environmentVariables.ADMIN_URL,
+ sitesConfig: JSON.parse(environmentVariables.SITES_CONFIG) as SitesConfig,
};
}

+ export type SitesConfig = Record<string, SiteConfig>;
```

2. Use the type when using `useSitesConfig`

```diff
- const sitesConfig = useSitesConfig();
+ const sitesConfig = useSitesConfig<SitesConfig>();
```

3. Optional: Remove type annotation from `ContentScopeProvider#resolveSiteConfigForScope` (as it's now inferred)

```diff
- resolveSiteConfigForScope: (configs: Record<string, SiteConfig>, scope: ContentScope) => configs[scope.domain],
+ resolveSiteConfigForScope: (configs, scope: ContentScope) => configs[scope.domain],
```
3 changes: 2 additions & 1 deletion .changeset/sixty-cobras-brake.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ Replace ContentScopeModule with UserPermissionsModule
Breaking changes:

- ContentScope-Module has been removed
- canAccessScope has been moved to AccessControlService and renamed to isAllowedContentScope
- canAccessScope has been moved to AccessControlService and refactored into isAllowed
- contentScopes- and permissions-fields have been added to CurrentUser-Object
- role- and rights-fields has been removed from CurrentUser-Object
- AllowForRole-decorator has been removed
- Rename decorator SubjectEntity to AffectedEntity
Expand Down
23 changes: 0 additions & 23 deletions .changeset/smart-weeks-behave.md

This file was deleted.

30 changes: 30 additions & 0 deletions .changeset/stale-wombats-reply.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
"@comet/admin": major
---

Change the signatures of `shouldScrollToField`, `shouldShowFieldError` and `shouldShowFieldWarning` in `FinalFormContext` to match the corresponding methods in `Field`

The API in `FinalFormContext` was changed from

```tsx
// ❌
export interface FinalFormContext {
shouldScrollToField: ({ fieldMeta }: { fieldMeta: FieldMetaState<any> }) => boolean;
shouldShowFieldError: ({ fieldMeta }: { fieldMeta: FieldMetaState<any> }) => boolean;
shouldShowFieldWarning: ({ fieldMeta }: { fieldMeta: FieldMetaState<any> }) => boolean;
}
```

to

```tsx
// ✅
export interface FinalFormContext {
shouldScrollToField: (fieldMeta: FieldMetaState<any>) => boolean;
shouldShowFieldError: (fieldMeta: FieldMetaState<any>) => boolean;
shouldShowFieldWarning: (fieldMeta: FieldMetaState<any>) => boolean;
}
```

Now the corresponding methods in `Field` and `FinalFormContext` have the same signature.

5 changes: 0 additions & 5 deletions .changeset/tricky-adults-laugh.md

This file was deleted.

23 changes: 0 additions & 23 deletions .changeset/yellow-seahorses-lick.md

This file was deleted.

2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ API_PORT=4000
API_URL=http://localhost:$API_PORT
API_URL_INTERNAL=http://localhost:$API_PORT
CORS_ALLOWED_ORIGINS="^http:\/\/localhost:\d+,^http://192.168.\d+.\d+:80[0-9]{2}"
SITE_PREVIEW_SECRET=uxa4ZBJ4exw8jgq-qrh

# blob storage
BLOB_STORAGE_DRIVER="file"
Expand All @@ -65,6 +64,7 @@ SITE_PORT=3000
SITE_URL=http://localhost:$SITE_PORT
SITE_PRELOGIN_ENABLED=false
SITE_PRELOGIN_PASSWORD=password
PREVIEW_URL=$SITE_URL/preview
# no gtm in dev mode
NEXT_PUBLIC_GTM_ID=
NEXT_PUBLIC_SITE_DOMAIN=main
Expand Down
4 changes: 4 additions & 0 deletions .github/auto_assign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@ addReviewers: true

reviewers:
- johnnyomair

skipKeywords:
- Merge main into next
- Version Packages
4 changes: 2 additions & 2 deletions copy-schema-files.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const fs = require("fs");
fs.promises.copyFile("demo/api/block-meta.json", "demo/site/block-meta.json"),
fs.promises.copyFile("demo/api/schema.gql", "demo/admin/schema.gql"),
fs.promises.copyFile("demo/api/schema.gql", "demo/site/schema.gql"),
fs.promises.copyFile("demo/api/comet-config.json", "demo/site/comet-config.json"),
fs.promises.copyFile("demo/api/comet-config.json", "demo/admin/comet-config.json"),
fs.promises.copyFile("demo/api/src/comet-config.json", "demo/site/src/comet-config.json"),
fs.promises.copyFile("demo/api/src/comet-config.json", "demo/admin/src/comet-config.json"),
]);
})();
2 changes: 1 addition & 1 deletion demo/admin/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ lang-compiled
graphql.generated.ts
block-meta.json
src/blocks.generated.ts
comet-config.json
src/comet-config.json
src/**/*.generated.ts
1 change: 0 additions & 1 deletion demo/admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"generate-block-types:watch": "chokidar -s \"**/block-meta.json\" -c \"npm run generate-block-types\"",
"gql:types": "graphql-codegen",
"gql:watch": "graphql-codegen --watch",
"postinstall": "cd server && npm install",
"intl:compile": "run-p intl:compile:comet intl:compile:comet-demo",
"intl:compile:comet": "formatjs compile-folder --format simple --ast lang/comet-lang lang-compiled/comet-lang",
"intl:compile:comet-demo": "formatjs compile-folder --format simple --ast lang/comet-demo-lang lang-compiled/comet-demo-lang",
Expand Down
Loading
Loading