Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COM-218: Remove endAdornment from FinalFormSelect #1703

Merged
merged 4 commits into from
Mar 14, 2024
Merged

COM-218: Remove endAdornment from FinalFormSelect #1703

merged 4 commits into from
Mar 14, 2024

Conversation

jomunker
Copy link
Contributor

Description

This PR removes the endAdornment Prop from the FinalFormSelect component, because it's also used internally for a clearing icon button (clearable prop).

@jomunker jomunker self-assigned this Feb 15, 2024
jamesricky
jamesricky reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incompatible change, as it removes the ability to set the endAdornment prop on FinalFormSelect, correct? Then please add a changeset for that.

johnnyomair
johnnyomair requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset for this breaking change

@johnnyomair johnnyomair changed the title COM-218: remove endAdornment from FinalFormSelect COM-218: Remove endAdornment from FinalFormSelect Feb 19, 2024
jamesricky
jamesricky previously approved these changes Mar 13, 2024
View reviewed changes
@thomasdax98 thomasdax98 merged commit be4e639 into next Mar 14, 2024
10 checks passed
@thomasdax98 thomasdax98 deleted the COM-218-remove-endAdornment-from-FinalFormSelect branch March 14, 2024 11:31
@jamesricky jamesricky mentioned this pull request Dec 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

@thomasdax98 thomasdax98 thomasdax98 approved these changes

@jamesricky jamesricky jamesricky approved these changes

Assignees

@jomunker jomunker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jomunker @jamesricky @thomasdax98 @johnnyomair