Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-357: Add import source as column in DAM grid #1756

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Feb 26, 2024

The import source column is only shown if importSources is provided via DamConfigProvider. This is done to not show the column if no external DAMs are supported.


image
  • Add changeset (if necessary)

Alternative to #1697

The import source column is only shown if `importSourceTypeLabels` is provided via `DamConfigProvider`. This is done to not show the column if no external DAMs are supported.
@johnnyomair johnnyomair self-assigned this Feb 26, 2024
@johnnyomair
Copy link
Collaborator Author

The import source column is only shown if importSourceTypeLabels is provided via DamConfigProvider. This is done to not show the column if no external DAMs are supported.

What do you think of this automatism?

nsams
nsams previously approved these changes Feb 27, 2024
thomasdax98
thomasdax98 previously approved these changes Feb 27, 2024
@johnnyomair johnnyomair dismissed stale reviews from thomasdax98 and nsams via 0fc2cb3 February 28, 2024 09:16
@johnnyomair johnnyomair merged commit 80e6fde into main Feb 28, 2024
10 checks passed
@johnnyomair johnnyomair deleted the COM-357-add-dam-import-source-column branch February 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants