Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-full-width fields in FieldSet #3097

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Allow non-full-width fields in FieldSet #3097

wants to merge 4 commits into from
+6 −6

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Jan 13, 2025 •
edited
Loading

Description

If child Fields are rendered without fullWidth, they won't have the correct width. Remove 'display: flex' to correct this.

Acceptance criteria

Screenshots/screencasts

Before After
Screenshot 2025-01-13 at 14 01 02 Screenshot 2025-01-13 at 14 01 02

Open TODOs/questions

  • Add changeset

Further information

@juliawegmayr juliawegmayr self-assigned this Jan 13, 2025
@juliawegmayr juliawegmayr changed the base branch from main to next January 13, 2025 13:03
@juliawegmayr juliawegmayr marked this pull request as ready for review January 13, 2025 13:04
@auto-assign auto-assign bot requested a review from johnnyomair January 13, 2025 13:04
@juliawegmayr juliawegmayr requested review from jamesricky and johnnyomair and removed request for johnnyomair January 13, 2025 13:04
@juliawegmayr @johnnyomair
Improve changeset
462ab3a 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johnnyomair johnnyomair changed the title Remove flex on fieldset Allow non-full-width fields in FieldSet Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

@jamesricky jamesricky jamesricky approved these changes

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliawegmayr @jamesricky @johnnyomair