Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUI Dialog mobile styling adaptions #3144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MUI Dialog mobile styling adaptions #3144

wants to merge 4 commits into from
+31 −7

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Jan 15, 2025 •
edited by jamesricky
Loading

Description

Adjust the spacings of MuiDialogTitle, MuiDialogContent and MuiDialogActions on mobile according to design

Acceptance criteria

Screenshots/screencasts

Before After
Screenshot 2025-01-15 at 08 40 30 Screenshot 2025-01-15 at 08 40 42

Open TODOs/questions

  • Add changeset

Further information

@juliawegmayr juliawegmayr changed the title adapt padding of Dialog elements for mobile screens MUI Dialog mobile styling adaptions Jan 15, 2025
@juliawegmayr juliawegmayr self-assigned this Jan 15, 2025
@juliawegmayr juliawegmayr force-pushed the dialog-system-mobile-styling branch from f522da2 to 59ed4f1 Compare January 15, 2025 08:12
@juliawegmayr juliawegmayr marked this pull request as ready for review January 15, 2025 08:14
@auto-assign auto-assign bot requested a review from johnnyomair January 15, 2025 08:14
@juliawegmayr juliawegmayr requested review from jamesricky and johnnyomair and removed request for johnnyomair January 15, 2025 08:14
jamesricky
jamesricky reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use use the theme spacing instead of the hardcoded padding values?

.changeset/eighty-zebras-rescue.md Outdated Show resolved Hide resolved
juliawegmayr and others added 2 commits January 15, 2025 11:36
@juliawegmayr @jamesricky
remove . from changeset
a9afd38 
Co-authored-by: Ricky James Smith <jamesricky@me.com>
@juliawegmayr
use spacing from theme instead of hardcoded values
db705f8
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesricky jamesricky jamesricky approved these changes

@johnnyomair johnnyomair Awaiting requested review from johnnyomair

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliawegmayr @jamesricky