Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wide tests for big_endian #24145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tankf33der
Copy link
Contributor

@tankf33der tankf33der commented Apr 6, 2025

My attempt fix tests for UTF16 in vlib/builtin/ for big_endian system(s).

Copy link

Connected to Huly®: V_0.6-22536

@tankf33der
Copy link
Contributor Author

I need a hint on how to make it work everywhere.

@tankf33der
Copy link
Contributor Author

I need a hint on how to make it work everywhere.

update: second attempt testing now.

@spytheman
Copy link
Member

Is it ok to merge it now?

@spytheman
Copy link
Member

We should research a way to run at least some tests (including the ones in vlib/builtin/) on a big endian system on the CI 🤔 .

@tankf33der
Copy link
Contributor Author

We should research a way to run at least some tests (including the ones in vlib/builtin/) on a big endian system on the CI 🤔 .

These patches will completely fix vlib/builtin/ for s390x (latest issues) and that's why pulsar was integrated.
And although this is not a real CI system, it's better than nothing.

@tankf33der
Copy link
Contributor Author

Is it ok to merge it now?

If patches are ok (not ugly) for you than yes.
From now vlib/builtin will be working for all systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants