feature: vote endpoint #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasmenendez
commented
Jan 7, 2025
lucasmenendez
commented
- Common structs refactored
- Initial endpoint to include a vote in a sequencer
- Tests endpoints to replace smart contract functionality
p4u
approved these changes
Jan 8, 2025
| ProcessesEndpoint = "/processes" | ||
| // ProcessEndpoint is the endpoint to get the process info | ||
| ProcessURLParam = "processId" | ||
| ProcessEndpoint = "/processes/{" + ProcessURLParam + "}" |
There was a problem hiding this comment.
I'd hardcode the full URL, I think it is OK and more readable.
Consider making all these constants private.
There was a problem hiding this comment.
I changed it because in this way we can reference the param to get the data in its place ensuring that if it changes, the new value is propagated in every place.
There was a problem hiding this comment.
If we make them private, then they will not be accessible by other packages like api/client...
| ProcessID types.HexBytes `json:"processId"` | ||
| Commitment types.HexBytes `json:"commitment"` | ||
| Nullifier types.HexBytes `json:"nullifier"` | ||
| Cipherfields elgamal.Ciphertexts `json:"cipherfields"` |
There was a problem hiding this comment.
It should be a pointer to the struct
| Nullifier types.HexBytes `json:"nullifier"` | ||
| Cipherfields elgamal.Ciphertexts `json:"cipherfields"` | ||
| CensusProof types.CensusProof `json:"censusProof"` | ||
| BallotProof parser.CircomProof `json:"ballotProof"` |
| CensusProof types.CensusProof `json:"censusProof"` | ||
| BallotProof parser.CircomProof `json:"ballotProof"` | ||
| BallotInputsHash types.HexBytes `json:"ballotInputsHash"` | ||
| PublicKey types.HexBytes `json:"publicKey"` |
There was a problem hiding this comment.
I'd not include PublicKey here, the Sequencer must take it from the State instead.
|
It is so far to be done that it is not yet ready for review. |
…roof verification key to verify the proof provided by the user, new comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.