Skip to content

feat(vapor): vapor keepalive #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: vapor
Choose a base branch
from
Open

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 10, 2025

Compiler Changes

  • In Vapor component, KeepAlive is compiled into VaporKeepAlive.

Runtime Changes

  • Introduced the VaporKeepAlive component:
    • For VaporComponent, it caches the component instance.
    • For VDOM components, it caches the Fragment.
  • The VDOM KeepAlive component now supports rendering Vapor components.

Tests

  • Ported all existing VDOM KeepAlive test cases.
  • Added E2E tests verifying that VaporKeepAlive supports rendering VDOM components.
  • Modified vdomInterop tests to include test cases for VDOM KeepAlive rendering Vapor components.

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit f84427b
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6801b4491f7fb000080a76d1
😎 Deploy Preview https://deploy-preview-13186--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13186

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13186

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13186

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13186

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13186

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13186

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13186

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13186

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13186

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13186

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13186

vue

npm i https://pkg.pr.new/vue@13186

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13186

commit: f84427b

@edison1105 edison1105 force-pushed the edison/feat/vaporKeepAlive branch from c7152bf to e012bc5 Compare April 10, 2025 07:30
@edison1105 edison1105 added the scope: vapor related to vapor mode label Apr 10, 2025
@edison1105 edison1105 force-pushed the edison/feat/vaporKeepAlive branch from 0a7d56d to a5a9f26 Compare April 14, 2025 07:51
@edison1105 edison1105 force-pushed the edison/feat/vaporKeepAlive branch from a5a9f26 to 6efc7ec Compare April 14, 2025 08:16
@edison1105 edison1105 force-pushed the edison/feat/vaporKeepAlive branch from 67498b5 to 252f647 Compare April 15, 2025 05:53
@edison1105 edison1105 marked this pull request as ready for review April 18, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant