feat[venom]: stack order analysis #4646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
+ Coverage 93.20% 93.22% +0.02%
==========================================
Files 131 132 +1
Lines 19169 19322 +153
Branches 3292 3330 +38
==========================================
+ Hits 17866 18013 +147
- Misses 884 889 +5
- Partials 419 420 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vyper/venom/passes/dft.py
Outdated
|
|
||
| while len(worklist) > 0: | ||
| bb = worklist.popleft() | ||
| stack_order = self.stack_order.handle_bbs(list(self.cfg.cfg_out(bb))) |
There was a problem hiding this comment.
does the liveness need to be recomputed for these bbs?
Stack order rewrite
harkal
reviewed
Sep 3, 2025
vyper/venom/analysis/stack_order.py
Outdated
| self.stack.append(src) | ||
| elif src in next_live: | ||
| self.stack.append(src) | ||
| if src in self.stack: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
inter bb stack analysis
How I did it
used the intra bb analysis (dft) as a base for the inter bb by propagating the information between the basic blocks
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture