-
-
Notifications
You must be signed in to change notification settings - Fork 863
refactor[codegen]: refactor assembly #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[codegen]: refactor assembly #4663
Conversation
explicit Label/PUSHLABEL instructions.
we probably should do the same for PUSH_OFST? Line 1081 in b460352
|
and maybe even |
it's not really a correctness issue, worst case there is a label that could have been removed but isn't (and is referenced by a push_ofst or data item) |
yeah, i think this is correct. let's add a comment though, it's a bit confusing that they are missing |
What I did
remove recursion from assembly. continuation of #4629
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture