chore: refactor command structure #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
update-app-patterns
branch
from
6c7e00f to
0018605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make no functional changes. Instead this is a quality-of-life change to make it easier to work with the CLI options and decoupling a lot of the just-in-time config parsing mixed in with the business logic (in CI rule and ui packages). Now all of the config/viper configuration parsing lives purely under the
cmdpackage. This also brings in CLI-level testing so we can ensure that flag and config options are parsed by cobra/viper in a way that we expect and is testable. Additionally any UI interaction is strongly separated from the business logic by using a bus to emit events which the UI responds to and having an adapter layer to emit these events for the majority of interactions, decorating business-level objects to observe any interactions.Ultimately, when merged, this should set a better foundation for the application as a whole (to build upon when adding features in the future).