-
Notifications
You must be signed in to change notification settings - Fork 236
Support JDK 24 #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JDK 24 #1490
Conversation
Test Results 720 files - 107 720 suites - 107 3h 55m 10s ⏱️ - 44m 39s Results for commit 24aca4d. ± Comparison against base commit 73f26c8. This pull request removes 118 and adds 101 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
One this passes review I will update the required job names for CI appropriately. |
shrike/src/main/java/com/ibm/wala/shrike/shrikeCT/ClassReader.java
Outdated
Show resolved
Hide resolved
@liblit can I get another review on this one? Merged in your Gradle 8.14 update. Thanks! |
Fixes #1491
As usual, we verify existing tests don't crash on JDK 24 bytecodes, but we haven't added or tested support for any new features.
We update to Gradle 8.14 RC1 as that version supports running on JDK 24. We also shift to using Zulu JDK builds wherever possible. Temurin has enabled JEP 493 for their JDK 24 builds (see adoptium/temurin-build#4035) which means they are distributed without
.jmod
files. This breaks WALA's strategy for loading Java standard library classes from the running VM if no other location is specified. We need to update the wiki to document this new requirement for JDK 24+ JVMs.